This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[DO NOT MERGE] Use mkl cmake flag to force DNNL to delegate FC op to MKL #18338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, for GEMM ops [DNNL delegates that op to MKL]
However, for FC DNNL doesn't.
Workaround : export USE_MKL & pass location of MKL installation.
This forces DNNL to delegate ops to MKL
This PR tries to verify correctness of the workaround [if it breaks any unit-tests]
@leezu @PatricZhao @TaoLv @kpuatamazon @kpu
This PR is not meant to be merged. But to serve as a proxy for internal releases.
If it passes the CI without issues, PR will be closed.
Pipelines to be watched for : windows-cpu, unix-cpu & centos-cpu
Specifically mkldnn/mkl builds.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.