Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix MKLDNN headers missing in nightly builds #18310

Merged
merged 1 commit into from
May 15, 2020
Merged

Fix MKLDNN headers missing in nightly builds #18310

merged 1 commit into from
May 15, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented May 14, 2020

Fixes #18120

@leezu leezu requested a review from szha as a code owner May 14, 2020 00:49
@mxnet-bot
Copy link

Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, edge, sanity, miscellaneous, clang, windows-gpu, unix-gpu, centos-cpu, website, centos-gpu, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

mseth10
mseth10 approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TaoLv
TaoLv approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@TaoLv TaoLv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@TaoLv
Copy link
Member

TaoLv commented May 14, 2020

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@leezu
Copy link
Contributor Author

leezu commented May 14, 2020

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@leezu
Copy link
Contributor Author

leezu commented May 15, 2020

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@leezu leezu merged commit fec534a into master May 15, 2020
@leezu leezu deleted the leezu-patch-4 branch May 15, 2020 05:55
MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Jun 23, 2020
@leezu @MoisesHer
cherry-pick: Fix missing MKLDNN headers (apache#18310)
a6abf75
@MoisesHer MoisesHer mentioned this pull request Jun 23, 2020
Merged
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
@leezu @AntiZpvoh
Fix missing MKLDNN headers (apache#18310)
e4a5b6e
sandeep-krishnamurthy pushed a commit that referenced this pull request Jul 20, 2020
@MoisesHer @leezu
Cherry-pick #18310 #18355 (#18608)
d95de55 
* cherry-pick: Fix missing MKLDNN headers (#18310)

* Include all mkldnn headers in CD builds (#18355)

* Fix cmake mkldnn install target. Previously mkldnn headers are installed to CMAKE_INSTALL_INCLUDEDIR instead of CMAKE_INSTALL_INCLUDEDIR/mkldnn

* Fix pypi_package.sh pip/setup.py for mkldnn builds

* Set CMAKE_CUDA_COMPILER in aarch64-linux-gnu-toolchain.cmake (#18713)

CMAKE_CUDA_HOST_COMPILER will be reset if CMAKE_CUDA_COMPILER is not set as of cmake 3.17.3

See https://gitlab.kitware.com/cmake/cmake/-/issues/20826

Co-authored-by: Leonard Lausen <[email protected]>
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Jul 27, 2020
@MoisesHer @leezu @ChaiBapchya
Cherry-pick apache#18310 apache#18355 (apache#18608)
f0cf1de 
* cherry-pick: Fix missing MKLDNN headers (apache#18310)

* Include all mkldnn headers in CD builds (apache#18355)

* Fix cmake mkldnn install target. Previously mkldnn headers are installed to CMAKE_INSTALL_INCLUDEDIR instead of CMAKE_INSTALL_INCLUDEDIR/mkldnn

* Fix pypi_package.sh pip/setup.py for mkldnn builds

* Set CMAKE_CUDA_COMPILER in aarch64-linux-gnu-toolchain.cmake (apache#18713)

CMAKE_CUDA_HOST_COMPILER will be reset if CMAKE_CUDA_COMPILER is not set as of cmake 3.17.3

See https://gitlab.kitware.com/cmake/cmake/-/issues/20826

Co-authored-by: Leonard Lausen <[email protected]>
szha pushed a commit that referenced this pull request Aug 3, 2020
@ChaiBapchya @MoisesHer @leezu
[v1.x] Mkldnn header fix v1x for nightly binaries (#18797)
2aa2702 
* Cherry-pick #18310 #18355 (#18608)

* cherry-pick: Fix missing MKLDNN headers (#18310)

* Include all mkldnn headers in CD builds (#18355)

* Fix cmake mkldnn install target. Previously mkldnn headers are installed to CMAKE_INSTALL_INCLUDEDIR instead of CMAKE_INSTALL_INCLUDEDIR/mkldnn

* Fix pypi_package.sh pip/setup.py for mkldnn builds

* Set CMAKE_CUDA_COMPILER in aarch64-linux-gnu-toolchain.cmake (#18713)

CMAKE_CUDA_HOST_COMPILER will be reset if CMAKE_CUDA_COMPILER is not set as of cmake 3.17.3

See https://gitlab.kitware.com/cmake/cmake/-/issues/20826

Co-authored-by: Leonard Lausen <[email protected]>

* remove linux-gputoolchain

Co-authored-by: MoisesHer <[email protected]>
Co-authored-by: Leonard Lausen <[email protected]>
@bartekkuncer bartekkuncer mentioned this pull request Nov 23, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-haibin-lin eric-haibin-lin eric-haibin-lin approved these changes

@TaoLv TaoLv TaoLv approved these changes

@mseth10 mseth10 mseth10 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
MKLDNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MKLDNN header missing in recent mxnet nightly static builds
6 participants
@leezu @mxnet-bot @TaoLv @eric-haibin-lin @mseth10 @pengzhao-intel