Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix pylint astroid sanity issue #18275

Merged
merged 3 commits into from
May 11, 2020
Merged

Fix pylint astroid sanity issue #18275

merged 3 commits into from
May 11, 2020

Conversation

ChaiBapchya
Copy link
Contributor

Cherrypick 18e2014 from #18220

Description

Refer #18269

Fixes sanity issue in 1.x [was previously fixed in 1.7.x, master]

@leezu @nickguletskii Plz review/merge. Thanks.

@mxnet-bot
Copy link

Hey @ChaiBapchya , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, edge, unix-cpu, windows-gpu, centos-cpu, miscellaneous, website, sanity, centos-gpu, unix-gpu, windows-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@nickguletskii
Copy link
Contributor

LGTM, thanks!

@ChaiBapchya
Copy link
Contributor Author

Reverting the python3 restriction since the CI for 1.x branch has been py3 only [removal of py2]

@ChaiBapchya
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-merge]

@lanking520 lanking520 added the pr-awaiting-merge Review and CI is complete. Ready to Merge label May 11, 2020
@leezu leezu merged commit 38ec873 into apache:v1.x May 11, 2020
@ChaiBapchya ChaiBapchya deleted the patch-4 branch May 12, 2020 06:09
ChaiBapchya added a commit to ChaiBapchya/mxnet that referenced this pull request Aug 15, 2020
* Fix pylint astroid sanity issue

Cherrypick apache@18e2014 from apache#18220
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants