Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Port nd.random.multinomial to npx.sample_categorical #18272

Merged
merged 2 commits into from
May 11, 2020

Conversation

xidulu
Copy link
Contributor

@xidulu xidulu commented May 10, 2020

Description

#18270

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @xidulu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, windows-cpu, unix-gpu, centos-gpu, sanity, website, centos-cpu, windows-gpu, edge, unix-cpu, clang]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@sxjscience
Copy link
Member

@xidulu How about moving it to npx.random.categorical to make it more consistent?

@xidulu
Copy link
Contributor Author

xidulu commented May 11, 2020

@sxjscience

Done.

@zheyuye
Copy link
Contributor

zheyuye commented May 11, 2020

Currently this op and nd.sample_multinomial only accepting noralized probability as input, could we make it compatible with the log-odds like npx.random.bernoulli

@xidulu
Copy link
Contributor Author

xidulu commented May 11, 2020

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

Copy link
Member

@yzhliu yzhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to me. thanks @xidulu @sxjscience

@yzhliu yzhliu merged commit 9d44086 into apache:master May 11, 2020
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
…18272)

* port nd.multinomial to npx.sample_categorical

* move to npx.random
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants