Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Disable tests of numpy operators implemented with CustomOp #18151

Merged
merged 3 commits into from
Apr 24, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Apr 23, 2020

Description

#18144, #18025 disabled empty_like which causes hangs. The other 3 CustomOp based fallback operators are also prone to cause deadlock, as exemplified by http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu/detail/PR-18025/59/pipeline/425 where the hang occurs without np_empty_like test being run

@mxnet-bot
Copy link

Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, website, sanity, edge, centos-cpu, centos-gpu, windows-gpu, unix-cpu, clang, windows-cpu, miscellaneous]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@RuRo
Copy link
Contributor

RuRo commented Apr 23, 2020

You might also want to disable other tests, which indirectly use those operators.
A quick grep over the tests only revealed test_np_unary_bool_funcs, which uses np.empty_like.

Not sure, if there are any more. Also, gonna mention #18090 here, so that this PR appears in the issue.

@RuRo
Copy link
Contributor

RuRo commented Apr 24, 2020

I think, the _np in test_np_kron is numpy, not mxnet.numpy, so if you disabled that test because of the _np.unravel_index calls, then I think we can reenable that one since it's just pure numpy.

Nice idea, switching empty_like to ones_like in test_np_unary_bool_funcs though!

@leezu
Copy link
Contributor Author

leezu commented Apr 24, 2020

Thanks for catching that @RuRo

@leezu leezu merged commit 1c9274e into apache:master Apr 24, 2020
@leezu leezu deleted the disablenpfallbackopstests branch April 24, 2020 06:19
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants