Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.7.x] Backport #17885 #18128

Merged
merged 1 commit into from
Apr 23, 2020
Merged

[v1.7.x] Backport #17885 #18128

merged 1 commit into from
Apr 23, 2020

Conversation

samskalicky
Copy link
Contributor

Backport #17885

* add debug prints to debug error in CI

* add debug prints to debug error in CI

* remove prints

* initial commit

* enabled calling create for selector

* connected selector to call external class

* added code to remove temp graph attrs

* fixed build issues

* changed shape inference to use different attr names

* fixed selector class

* cleaned up APIs

* fixed sanity

* updated build for extensions

* sanity fix

* refactored MXLoadLib into separate functions

* undo rebase

* finished merge

* enabled verbose in library loading

* fixed example

* added passing args/aux down to graph pass

* added creating new args/aux for graph passes

* fixed return args/aux

* fixed sanity

* whitespace

* fixed lint

* updated perl API, README, added pass_lib to cmake build flow

* fixed mistake with relu example lib

* fixed perl syntax

* addressed comments

* addressed more comments

* fixed compile issues

Co-authored-by: Ubuntu <[email protected]>
Co-authored-by: Ubuntu <[email protected]>
@mxnet-bot
Copy link

Hey @samskalicky , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, clang, sanity, edge, website, unix-gpu, centos-cpu, unix-cpu, miscellaneous, windows-gpu, windows-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ciyongch
Copy link
Contributor

Thanks @samskalicky , adding this PR to 1.7.0 roadmap #16864.

@samskalicky
Copy link
Contributor Author

Thanks @ciyongch! This PR is finally ready to merge. The same #18126 on the v1.x branch has already been merged. @PatricZhao @ptrendx

@ciyongch
Copy link
Contributor

@samskalicky thanks to help backport this feature to v1.7.x, ping @TaoLv @pengzhao-intel to help merge.

@TaoLv TaoLv changed the title [1.7] Backport #17885 [v1.7.x] Backport #17885 Apr 23, 2020
@TaoLv TaoLv merged commit 4392b4c into apache:v1.7.x Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants