Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.x] Backport #17772 #18075

Merged
merged 1 commit into from
Apr 26, 2020
Merged

[1.x] Backport #17772 #18075

merged 1 commit into from
Apr 26, 2020

Conversation

mseth10
Copy link
Contributor

@mseth10 mseth10 commented Apr 15, 2020

Description

Backport #17772 to branch v1.x

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mseth10 mseth10 requested a review from szha as a code owner April 15, 2020 21:51
@mxnet-bot
Copy link

Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, website, centos-cpu, miscellaneous, clang, windows-gpu, centos-gpu, unix-gpu, windows-cpu, edge, sanity]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10
Copy link
Contributor Author

mseth10 commented Apr 15, 2020

@samskalicky @leezu please review

@leezu leezu changed the base branch from v1.7.x to v1.x April 15, 2020 22:15
@mseth10 mseth10 changed the title [1.7] Backport #17772 [1.x] Backport #17772 Apr 15, 2020
@mseth10
Copy link
Contributor Author

mseth10 commented Apr 20, 2020

@ciyongch @PatricZhao please help merge! thanks!

@mseth10
Copy link
Contributor Author

mseth10 commented Apr 20, 2020

@mxnet-label-bot add [pr-awaiting-merge]

@lanking520 lanking520 added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Apr 20, 2020
@ciyongch
Copy link
Contributor

@pengzhao-intel Please take a look and help merge.
@mseth10 can you backport this PR to v1.7.x release branch as well (as the code rebase was already done)? Thanks.

@ciyongch
Copy link
Contributor

@mseth10 please check the failed CI, and backport this PR to v1.7.x branch as well. :)

@mseth10
Copy link
Contributor Author

mseth10 commented Apr 22, 2020

Hi @ciyongch , the CI got re-triggered automatically on this PR. It was passing earlier.

I have created another PR for v1.7.x #18122

@ciyongch
Copy link
Contributor

Thanks @mseth10 , I will track that PR before code freeze.

@mseth10
Copy link
Contributor Author

mseth10 commented Apr 22, 2020

@leezu @pengzhao-intel @ciyongch please help merge this PR

@ciyongch
Copy link
Contributor

@TaoLv @pengzhao-intel please help to merge this PR, which is already merged in both master and v1.7.x.

@rondogency
Copy link
Contributor

@szha @leezu @eric-haibin-lin Can you help to merge this PR?

@pengzhao-intel pengzhao-intel merged commit 63e2b19 into apache:v1.x Apr 26, 2020
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

@mseth10 mseth10 deleted the v1.x_backport branch June 16, 2020 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants