Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix MKL static link & default to static link on unix #17751

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Mar 3, 2020

Fixes #17641

Changes

  • Fix MKL Static linkage and default to it on Unix
  • Don't build llvm openmp when linking to MKL. If MKL is present, intel omp is also present.

@leezu leezu requested a review from cjolivier01 March 3, 2020 18:55
@leezu leezu requested a review from szha as a code owner March 3, 2020 18:55
@TaoLv
Copy link
Member

TaoLv commented Mar 4, 2020

@leezu We're working on a proposal for the build logic of DNNL/MKL related stuffs. You can decide to merge this change now if urgent or wait for the proposal after it's ready. Thanks! @pengzhao-intel @zixuanweeei

@leezu
Copy link
Contributor Author

leezu commented Mar 4, 2020

@TaoLv thanks. Let's merge it now as building with mkl is currently broken without this PR. I look forward to your proposal

@leezu leezu merged commit 6368977 into apache:master Mar 4, 2020
@leezu leezu deleted the staticmkl branch March 4, 2020 16:56
@hubutui hubutui mentioned this pull request Mar 9, 2020
MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 10, 2020
* Fix MKL static link & default to static link on unix

Fixes apache#17641

* Test cmake MKL build on CI
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
* Fix MKL static link & default to static link on unix

Fixes apache#17641

* Test cmake MKL build on CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenMP Error
3 participants