This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran the entire opperf suite after making the changes Command
CPU & GPUhttps://gist.github.com/ChaiBapchya/517445961bcd57da6b7b5d23fa5d3dc0 |
Restarted windows CI |
4 tasks
connorgoggins
approved these changes
Mar 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your help rectifying these issues.
apeforest
reviewed
Mar 2, 2020
@mxnet-label-bot update [pr-awaiting-merge] |
MoisesHer
pushed a commit
to MoisesHer/incubator-mxnet
that referenced
this pull request
Apr 10, 2020
* cudnn expects eps to be >e105 and gamma1,gamma2 renamed in other PR * fix lamb_update_* ops * add var name for wd
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 29, 2020
* cudnn expects eps to be >e105 and gamma1,gamma2 renamed in other PR * fix lamb_update_* ops * add var name for wd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change 1 (Fix for rmsprop_update and rmsprop_alex_update)
After merging PR #17449 and #17400
refactor of optimizer was incomplete due to both PRs not knowing changes made by each other.
While #17449 added set of variables for large tensor, #17400 refactored 2 variables from gamma1 gamma2 to rho and momentum
Fixing that conflict here
Change 2 (Fix for BatchNorm)
Upon running entire opperf suite for CUDA=ON, CUDNN=ON, it was found BatchNorm fails here
Change 3 Fix for lamb_update_*
wd parameter was incorrectly omitted from default_params
Added it back
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.