Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] FFI: Bincount, Percentile/Quantile, All/Any #17717

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

Tommliu
Copy link
Contributor

@Tommliu Tommliu commented Feb 28, 2020

Description

Change Operator Registration of Bincount to FFI

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Tommliu Tommliu requested a review from szha as a code owner February 28, 2020 04:39
@Tommliu Tommliu force-pushed the ffi_bincount branch 3 times, most recently from f404846 to 61928b4 Compare February 28, 2020 07:09
@haojin2 haojin2 added the Numpy label Feb 28, 2020
@haojin2 haojin2 self-assigned this Feb 28, 2020
@Tommliu Tommliu changed the title [Numpy] FFI Bincount [Numpy] FFI: Bincount, Percentile/Quantile, All/Any Mar 4, 2020
@Tommliu Tommliu force-pushed the ffi_bincount branch 4 times, most recently from 43fcbae to 729082a Compare March 5, 2020 06:09
@Tommliu Tommliu force-pushed the ffi_bincount branch 5 times, most recently from 161127d to fd67ca4 Compare March 5, 2020 12:57
src/operator/numpy/np_percentile_op-inl.h Outdated Show resolved Hide resolved
src/api/operator/numpy/np_percentile_op.cc Outdated Show resolved Hide resolved
@haojin2 haojin2 merged commit 713d962 into apache:master Mar 10, 2020
@haojin2
Copy link
Contributor

haojin2 commented Mar 10, 2020

merged, better add some comments in some new wrappers in a future PR.

MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 10, 2020
* ffi_bincount percentile/quantile all/any

* new ffi
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
* ffi_bincount percentile/quantile all/any

* new ffi
sxjscience pushed a commit to sxjscience/mxnet that referenced this pull request Jul 1, 2020
* ffi_bincount percentile/quantile all/any

* new ffi
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants