This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Set Ninja build generator in config.cmake instead of commmand line #17639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeforest
reviewed
Feb 20, 2020
apeforest
reviewed
Feb 20, 2020
|
Thanks a lot for enhancing cmake build and instruction. This is almost a dream come true for MXNet developers :) |
apeforest
reviewed
Feb 21, 2020
apeforest
reviewed
Feb 21, 2020
| ``` | ||
|
|
||
| You can increase the `--parallel 8` argument to match the number of processor |
There was a problem hiding this comment.
I think we can leave this as an option in the doc. Some users may not want to use all the processors for compiling.
apeforest
reviewed
Feb 21, 2020
| ``` | ||
|
|
||
| You can increase the `--parallel 8` argument to match the number of processor |
There was a problem hiding this comment.
I think we can leave this as an option in the doc. Some users may not want to use all the processors for compiling.
apeforest
reviewed
Feb 21, 2020
apeforest
reviewed
Feb 21, 2020
apeforest
reviewed
Feb 21, 2020
leezu
force-pushed
the
cmakedefaultninja
branch
from
777dc6d
to
4810c23
Compare
leezu
force-pushed
the
cmakedefaultninja
branch
from
4810c23
to
84b886c
Compare
apeforest
approved these changes
Feb 21, 2020
|
@leezu I retriggered CI tests. |
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 29, 2020
- Set Ninja build generator in config.cmake instead of commmand line - Load config.cmake by default if present
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Comments
Thanks to @apeforest for the suggestion.
Also remove
--parallel 8argument from doc, as with ninja the number of cores is autodetected.