Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Disable test_np_nan_to_num for unblocking CI #17630

Closed
wants to merge 1 commit into from

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Feb 19, 2020

Description

As title.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@haojin2 haojin2 added the Numpy label Feb 19, 2020
@haojin2 haojin2 self-assigned this Feb 19, 2020
@haojin2 haojin2 added the CI label Feb 19, 2020
@haojin2
Copy link
Contributor Author

haojin2 commented Feb 20, 2020

@ptrendx Windows-gpu still failing after test_np_nan_to_num is disabled, I guess this failure is not related to tests themselves but rather the test environment. Also some other PRs passed this build without the tests disabled such as #17629.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant