Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Pin Markdown version to 3.1 in Julia doc build #17549

Merged
merged 1 commit into from
Feb 8, 2020

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Feb 7, 2020

Description

Fix for #16146

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link
Contributor

@access2rohit access2rohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix ! This was affecting all PRs

@access2rohit
Copy link
Contributor

@mxnet-label-bot add [pr-awaiting-merge]

@lanking520 lanking520 added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Feb 7, 2020
@haojin2
Copy link
Contributor Author

haojin2 commented Feb 8, 2020

unix-gpu build timing out again, just re-triggered, will merge this myself when I see this has passed.

@haojin2 haojin2 merged commit 5b50600 into apache:master Feb 8, 2020
@haojin2 haojin2 deleted the julia_doc_markdown_version_fix branch February 8, 2020 03:58
leezu pushed a commit to leezu/mxnet that referenced this pull request Feb 15, 2020
leezu added a commit that referenced this pull request Feb 17, 2020
* Fix transformer.cu interleaved matmul for cuda arch < 5  (#17596)

cublasGemmBatchedEx is only supported for GPU with architecture capabilities equal or greater than 5.0.

Fixes a bug in #16408

* pin Markdown version to 3.1 in Julia doc build (#17549)

* pin Sphinx due to autodocsumm issue with v4.2.0 (#17561)

* pin python dependencies (#17556)

* [CI] Fix static build pipeline (#17474)

* 1.5.x CI fixes (#17426)

* Fix numpy decorator

* Workaround pytest-dev/pytest#5903

* Disable pylint warnings

* Fix Edge build

* Fix numpy decorator on Centos

* Follow redirects when downloading apache-maven-3.3.9-bin.tar.gz

Co-authored-by: Hao Jin <[email protected]>
Co-authored-by: Aaron Markham <[email protected]>
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI Doc Julia pr-awaiting-merge Review and CI is complete. Ready to Merge Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants