This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[OpPerf] Fixes the issue when you pass NDArray to run_perf_test #17508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the issue when you pass NDArray to the opperf. It errors out
```
run_performance_test(nd.gather_nd, inputs=[{"data": (2, 22), "indices":nd.random_uniform(low=0,high=1,shape=(1,2))}], run_backward=T
rue, warmup=1, runs=1)
TypeError: isinstance() arg 2 must be a type or tuple of types
```
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/ubuntu/incubator-mxnet/benchmark/opperf/utils/benchmark_utils.py", line 133, in run_performance_test
args_list, kwargs_list = _prepare_op_inputs(inputs, run_backward, dtype, ctx)
File "/home/ubuntu/incubator-mxnet/benchmark/opperf/utils/benchmark_utils.py", line 50, in _prepare_op_inputs
attach_grad=run_backward)
File "/home/ubuntu/incubator-mxnet/benchmark/opperf/utils/ndarray_utils.py", line 120, in get_mx_ndarray
tensor = in_tensor.as_in_context(ctx=ctx).astype(dtype=dtype)
TypeError: as_in_context() got an unexpected keyword argument 'ctx'
|
@mxnet-label-bot add [pr-awaiting-review] |
zheyuye
pushed a commit
to zheyuye/incubator-mxnet
that referenced
this pull request
Feb 19, 2020
…he#17508) * Fix typeError Fixes the issue when you pass NDArray to the opperf. It errors out ``` run_performance_test(nd.gather_nd, inputs=[{"data": (2, 22), "indices":nd.random_uniform(low=0,high=1,shape=(1,2))}], run_backward=T rue, warmup=1, runs=1) TypeError: isinstance() arg 2 must be a type or tuple of types ``` * Fix unexpected keyword argument 'ctx' error Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/ubuntu/incubator-mxnet/benchmark/opperf/utils/benchmark_utils.py", line 133, in run_performance_test args_list, kwargs_list = _prepare_op_inputs(inputs, run_backward, dtype, ctx) File "/home/ubuntu/incubator-mxnet/benchmark/opperf/utils/benchmark_utils.py", line 50, in _prepare_op_inputs attach_grad=run_backward) File "/home/ubuntu/incubator-mxnet/benchmark/opperf/utils/ndarray_utils.py", line 120, in get_mx_ndarray tensor = in_tensor.as_in_context(ctx=ctx).astype(dtype=dtype) TypeError: as_in_context() got an unexpected keyword argument 'ctx'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upon running run_performance_test, user can input shape (as tuple) or NDArray directly in parameters that need NDArray.
Internally, opperf creates an NDArray if user has given shape as input. (default initializer is random_normal)
Now, when I pass an NDArray to run_perf_test follow issues occur
It errors out
The issue is at this line
elif isinstance(in_tensor, mx.ndarray):
It should check for nd.NDArray and not mx.ndarray
Test
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.