Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[OpPerf] Fix markdown for native profile and add profile param in function desc #17494

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

ChaiBapchya
Copy link
Contributor

@ChaiBapchya ChaiBapchya commented Jan 31, 2020

Description

  1. Fix markdown for native profile
    Native profile has 5 columns where as Python profile has 6
    Native : "| Operator | Avg Forward Time (ms) | Avg. Backward Time (ms) | Max Mem Usage (Storage) (Bytes) | Inputs |"
    Python : "| Operator | Avg Time (ms) | P50 Time (ms) | P90 Time (ms) | P99 Time (ms) | Inputs |")
    5 columns instead of 6 for native profile

  2. Add profile param in function descriptions

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Code is well-documented:
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

benchmark/opperf/utils/common_utils.py

Verified the markdown file that this generates.

@ChaiBapchya
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@connorgoggins @apeforest @access2rohit

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Jan 31, 2020
@ChaiBapchya ChaiBapchya changed the title [OpPerf] Fix markdown for native profile [OpPerf] Fix markdown for native profile and add profile param in function desc Jan 31, 2020
Copy link
Contributor

@connorgoggins connorgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work :)

@ChaiBapchya
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@access2rohit @apeforest

@ChaiBapchya
Copy link
Contributor Author

@ChaiBapchya
Copy link
Contributor Author

@mxnet-label-bot update [pr-awaiting-merge]

@lanking520 lanking520 added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Feb 4, 2020
@apeforest apeforest merged commit 513c365 into apache:master Feb 4, 2020
@ChaiBapchya ChaiBapchya deleted the fix_markdown branch February 4, 2020 22:11
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
…ction desc (apache#17494)

* 5 columns instead of 6 for native profile

* add profiler param in function description
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
…ction desc (apache#17494)

* 5 columns instead of 6 for native profile

* add profiler param in function description
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants