Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Disable flaky test test_operator_gpu.test_convolution_multiple_streams #17484

Closed

Conversation

ChaiBapchya
Copy link
Contributor

@ChaiBapchya ChaiBapchya commented Jan 30, 2020

Description

Title
See #14329

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Code is well-documented:
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@ChaiBapchya
Copy link
Contributor Author

@kshitij12345 @szha @TaoLv

@ChaiBapchya
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Jan 31, 2020
Copy link
Contributor

@kshitij12345 kshitij12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually wondering whether the whole test should be skipped or we have verified that it is crashing only with a particular engine like diagnosed in #14329 (ThreadedEngine)

@ChaiBapchya
Copy link
Contributor Author

Other PR already got merged #17499
Closing this one in favor of that

@ChaiBapchya ChaiBapchya closed this Feb 7, 2020
@ChaiBapchya ChaiBapchya deleted the disable_conv_multiple_streams branch February 14, 2020 23:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants