Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix np.argmax/argmin output data type #17476

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Jan 30, 2020

Description

Change the output types of np.argmax / np.argmin to be int64 instead of copying the input tensor's data type.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • New infertype and compute functions
  • Additional checks for output data type in unit test

Comments

@reminisce

@haojin2 haojin2 added the Numpy label Jan 30, 2020
@haojin2 haojin2 self-assigned this Jan 30, 2020
@haojin2 haojin2 merged commit ab8701a into apache:master Jan 30, 2020
@haojin2 haojin2 deleted the arg_type_fix branch January 30, 2020 05:20
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants