Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update ubuntu_publish.sh to fix get-pip issue Ubuntu 14.04 #17458

Closed
wants to merge 2 commits into from

Conversation

ChaiBapchya
Copy link
Contributor

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@ChaiBapchya
Copy link
Contributor Author

Taking specific commits from @leezu #17448 to address #17457 in v1.5.x
Hopefully this unblocks #17286 (fix lstm PR)

@leezu
Copy link
Contributor

leezu commented Jan 28, 2020

Probably need to include 9ef9b08 as well

@ChaiBapchya
Copy link
Contributor Author

Closing in favor of #17473

@ChaiBapchya ChaiBapchya deleted the patch-3 branch January 30, 2020 00:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants