Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

add disclaimer #17428

Merged
merged 5 commits into from
Jan 28, 2020
Merged

add disclaimer #17428

merged 5 commits into from
Jan 28, 2020

Conversation

roywei
Copy link
Member

@roywei roywei commented Jan 24, 2020

address #17329 (comment)
so we can move forward with 1.6 release.

cc @ptrendx @szha @leezu @samskalicky

szha
szha previously requested changes Jan 25, 2020
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The WIP disclaimer should replace the content of the existing disclaimer, not to be included side by side with the old disclaimer
Nevermind. The examples I found doesn't conform to the requirement in the disclaimer guideline page.

@szha szha dismissed their stale review January 25, 2020 15:13

Based on wrong examples.

Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roywei
Copy link
Member Author

roywei commented Jan 27, 2020

Yes, i think the file should be kept separate according to here

For releases, the text SHOULD be included in a separate DISCLAIMER-WIP file stored alongside the NOTICE and LICENSE files.

re-trigger CI.

@roywei
Copy link
Member Author

roywei commented Jan 27, 2020

rebased and Jenkins God please no time-out 🙏 🙏 🙏

@roywei
Copy link
Member Author

roywei commented Jan 28, 2020

replaced DISCLAIMER with DISCLAIMER-WIP file, updated CI/CD scripts

Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tools/pip/MANIFEST.in also needs to be updated.

@roywei
Copy link
Member Author

roywei commented Jan 28, 2020

tools/pip/MANIFEST.in also needs to be updated.

done

@roywei roywei merged commit 910c608 into apache:master Jan 28, 2020
roywei added a commit to roywei/incubator-mxnet that referenced this pull request Jan 28, 2020
* add disclaimer

* add white list

* fix exclude

* remove disclaimer

* update tools/pip
szha pushed a commit that referenced this pull request Jan 29, 2020
* Update NOTICE to fix copyright years (#17330)

* Update LICENSE for fonts (#17365)

* license np_einsum file under bsd (#17367)

* license under bsd

* fix rat exclude

* remove unused file with license issue (#17371)

* [LICENSE] fix cpp predcit license (#17377)

* fix cpp predcit license

* add white list (#210)

* fix white list (#211)

Co-authored-by: Lai Wei <[email protected]>

* add disclaimer (#17428)

* add disclaimer

* add white list

* fix exclude

* remove disclaimer

* update tools/pip

Co-authored-by: Haibin Lin <[email protected]>
@roywei roywei deleted the disclaimer branch January 29, 2020 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants