Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

cmake: remove outdated comments #17413

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Jan 23, 2020

No description provided.

"Only add c++11 flags and definitions after cuda compiling" is not true anymore
@leezu leezu requested a review from szha as a code owner January 23, 2020 00:48
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
else()
if(MSVC)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously it was added after cuda compiling

  1. why was it done before?
  2. why is it no longer needed?
    Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why it was done before. @jermainewang added the comment and may be able to clarify.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no longer needed as the build works fine without it.

@leezu leezu added the pr-awaiting-review PR is waiting for code review label Jan 25, 2020
@szha szha added the CMake CMake related bugs/issues/improvements label Jan 29, 2020
@szha szha merged commit 5631c13 into apache:master Jan 29, 2020
@leezu leezu deleted the cmakeremoveoutdatedcomments branch January 29, 2020 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CMake CMake related bugs/issues/improvements pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants