-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Implemented final two binary ops, added default params for functionality #17407
Implemented final two binary ops, added default params for functionality #17407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your first contribution! More to come!
Please add results seen on CPU/GPU for reference. |
A gist link with the results would do |
Also you could run the opperf utility by specifying the file format and name of the file |
@mxnet-label-bot update [pr-awaiting-review] |
Also it would make sense to add results for
Just to ensure it is fool-proof. |
Let's add ElementwiseSum op too |
Full OpPerf test (CPU): https://gist.github.com/connorgoggins/d39b9adc63c3efabe81cfac34c5dfe1a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Not in this PR but in one of the other 3 PRs that you have open you can add yourself to the Contributors.md file |
Incorrect way to rebase @connorgoggins First get your master branch updated
Once your fork master is sync'ed with remote master, rebase your branch on master
Let me know if this works! |
9b917a5
to
85b2f07
Compare
85b2f07
to
98c7d07
Compare
…ity (apache#17407) * Implemented final two binary ops, added default params for functionality * Removed extraneous param checks * Added support for ElementWiseSum * Moved ElementWiseSum to binary_element_wise_operators
…ity (apache#17407) * Implemented final two binary ops, added default params for functionality * Removed extraneous param checks * Added support for ElementWiseSum * Moved ElementWiseSum to binary_element_wise_operators
Description
Added implementation for
reshape_like
andchoose_element_0index
in opperf, as well as supporting variables inrules/default_params.py
.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes