This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix reshape interoperability test (#17155) #17346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix reshape interoperability test * fix for scipy import
reminisce
reviewed
Jan 16, 2020
ci/docker/install/docs_requirements
Outdated
| @@ -26,11 +26,11 @@ h5py==2.8.0rc1 | |||
| mock==2.0.0 | |||
| nose==1.3.7 | |||
| nose-timer==0.7.3 | |||
| numpy>1.16.0,<2.0.0 | |||
| numpy>1.16.0,<1.18.0 | |||
There was a problem hiding this comment.
Why is there a restriction on the numpy version? I think it has been fixed in master.
There was a problem hiding this comment.
I was told it was this PR's fix that helped resolve the issue #17154
leezu
reviewed
Jan 23, 2020
|
Weird thing On the same branch python-dateutil==2.7.2 has been pinned... not sure why it doesn't pick that up. |
Merged
|
Closing in favor of #17426 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix reshape interoperability test
fix for scipy import
Description
To fix the numpy.decorator issue in #17286
@haojin2 @frankfliu @reminisce