Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

grouping large vector tests based on their type and adding their nightly test function #17306

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

access2rohit
Copy link
Contributor

@access2rohit access2rohit commented Jan 14, 2020

Description

Grouped large vector tests for large tensor support into 3:

  • tensor (creation and manipulation)
  • nn (neural network)
  • basic (arithmetic and logical)

calling 4 groups separately in nightly run so memory is freed by after every group run.

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

Currently running, will update once they finish

@access2rohit
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Jan 14, 2020
@access2rohit
Copy link
Contributor Author

@apeforest @ChaiBapchya PR is ready for review

@access2rohit access2rohit force-pushed the vector_grouping branch 2 times, most recently from ac931fb to 54d1faa Compare January 15, 2020 00:53
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retriggered unix-cpu and unix-gpu for you (both had 1 job that timed out due to 4hr+ run) Suspicious why the time-outs have resurfaced.

Also awaiting to see results posted of running these nosetests on your test machine. Thanks
Rest LGTM!

Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apeforest apeforest merged commit 04c3eec into apache:master Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants