This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Cuda root dir is not specified, search for the symlinked unix default
FindCUDAToolkit exposes result variables (cmake variables). Use those. https://github.com/apache/incubator-mxnet/blob/28e053edb4f2079743458bf087557bcac7e58c62/cmake/Modules/FindCUDAToolkit.cmake#L427-L464
apeforest
reviewed
Jan 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm except for a few cosmetic change
leezu
reviewed
Jan 14, 2020
Verified this works by running following
Python binding
|
@mxnet-label-bot add [pr-awaiting-review] |
leezu
reviewed
Jan 15, 2020
apeforest
reviewed
Jan 16, 2020
Also add warning about deprecation
Also @leezu any idea why it's failing for Windows CPU Cmake. Unable to discern from the Error log. |
Not sure. I restarted the job to make sure it's not an intermittent issue. |
Wow! It passed! Weird! @leezu thanks for retrigger |
apeforest
reviewed
Jan 17, 2020
apeforest
reviewed
Jan 17, 2020
@ChaiBapchya Please fix the indent problem as I pointed out. Otherwise, this PR is good to go for me. |
leezu
reviewed
Jan 21, 2020
apeforest
approved these changes
Jan 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17239
Checklist
Essentials
Changes
modified: cmake/Modules/FindNCCL.cmake
Test
Tested with following command
Without this branch, it failed with NCCL not found
With this PR, it passes.