Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fixing gather op in large vector and array #17290

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

access2rohit
Copy link
Contributor

@access2rohit access2rohit commented Jan 13, 2020

adding asnumpy() to output of gather(implicitly called) to fix gather test in large vector and tensor tests

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • Code is well-documented:
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Testing

ubuntu@ip-172-31-82-110 ~/incubator-mxnet (array_grouping) $ MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose -s tests/nightly/test_large_array.py:test_gather
/home/ubuntu/anaconda3/lib/python3.6/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
test_large_array.test_gather ... ok

----------------------------------------------------------------------
Ran 1 test in 1.838s

OK

ubuntu@ip-172-31-82-110 ~/incubator-mxnet (array_grouping) $ MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose -s tests/nightly/test_large_vector.py:test_gather
/home/ubuntu/anaconda3/lib/python3.6/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
test_large_vector.test_gather ... ok

----------------------------------------------------------------------
Ran 1 test in 1.608s

OK

@access2rohit
Copy link
Contributor Author

access2rohit commented Jan 13, 2020

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Jan 13, 2020
@access2rohit
Copy link
Contributor Author

@apeforest @ChaiBapchya PR ready for review

Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird how we didn't catch this issue when PR #16371 was introduced.
Thanks for the fix nonetheless!

@apeforest apeforest merged commit 71e70f2 into apache:master Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants