Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Handle extra cases for np.full #17245

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Jan 8, 2020

Description

Handling the case when fill_value is an ndarray.
Additional unit test for np.full has been added too.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Implement ndarray case for fill_value argument
  • New unit test

Comments

With minor improvement for docs

@haojin2 haojin2 added the Numpy label Jan 8, 2020
@haojin2 haojin2 requested a review from reminisce January 8, 2020 04:03
@haojin2 haojin2 requested a review from szha as a code owner January 8, 2020 04:03
@haojin2 haojin2 self-assigned this Jan 8, 2020
@haojin2 haojin2 changed the title Handle extra cases for np.fill Handle extra cases for np.full Jan 8, 2020
@reminisce reminisce merged commit 2938684 into apache:master Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants