Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Minor fix, use RAII for TensorRT builder and network object #17189

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

litaotju
Copy link
Contributor

@litaotju litaotju commented Dec 28, 2019

Description

Both the nvinfer1::INetworkDefinition and nvinfer1::IBuilder class has destroy method to destruct the object, and can use the RAII class InferObject, but original code before this PR does not use this one. This PR enhanced the robustness, espescially when the function throws.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@litaotju
Copy link
Contributor Author

litaotju commented Dec 31, 2019

@szha , this is my first commit to this project. Trying to get myself familiar with the project by minor fix. Found I can not request review for this. Do you know what's the proper process for review on such fix? How do I specify reviewers?

(I Saw you name in serveral reviews, so trying to find your help here. Hope you don't mind). Thanks.

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution!

@wkcn wkcn added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Jan 8, 2020
@wkcn
Copy link
Member

wkcn commented Jan 9, 2020

Hi @ptrendx , could you please help take a review? Thank you!

@wkcn wkcn merged commit 651eb9d into apache:master Jan 10, 2020
@wkcn
Copy link
Member

wkcn commented Jan 10, 2020

Merged. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants