Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[numpy] add op median #17084

Merged
merged 3 commits into from
Apr 2, 2020
Merged

[numpy] add op median #17084

merged 3 commits into from
Apr 2, 2020

Conversation

Yiyan66
Copy link
Contributor

@Yiyan66 Yiyan66 commented Dec 16, 2019

Description

add op median

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Yiyan66 Yiyan66 requested a review from szha as a code owner December 16, 2019 07:11
@haojin2 haojin2 added the Numpy label Dec 16, 2019
@haojin2 haojin2 self-assigned this Dec 16, 2019
@Yiyan66 Yiyan66 force-pushed the median branch 4 times, most recently from 57bd1c3 to b9904c0 Compare December 27, 2019 08:04
haojin2
haojin2 approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will re-trigger the CI builds to make this pass

@Yiyan66 Yiyan66 force-pushed the median branch 2 times, most recently from 0500a7c to 014da10 Compare February 29, 2020 03:19
@Yiyan66
Copy link
Contributor Author

Yiyan66 commented Apr 1, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@Yiyan66
Copy link
Contributor Author

Yiyan66 commented Apr 1, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@haojin2 haojin2 merged commit 08528c5 into apache:master Apr 2, 2020
@TaoLv
Copy link
Member

TaoLv commented Apr 5, 2020

@Yiyan66 @haojin2 Is the down grade of 3rdparth/mkldnn intended or a mistake?

@TaoLv TaoLv mentioned this pull request Apr 6, 2020
Closed
@ChaiBapchya ChaiBapchya mentioned this pull request Apr 6, 2020
Merged
3 tasks
TaoLv added a commit to TaoLv/incubator-mxnet that referenced this pull request Apr 7, 2020
@TaoLv
Revert "[numpy] add op median (apache#17084)"
39cb255 
This reverts commit 08528c5.
@TaoLv
Copy link
Member

TaoLv commented Apr 7, 2020

@Yiyan66 @haojin2 It seems the submodule change is a mistake. I'm going the revert this PR to get the right version back and unblock related PRs. Please reorganize you code changes and submit the PR again. Sorry for the inconvenience.

@TaoLv TaoLv mentioned this pull request Apr 7, 2020
Closed
7 tasks
@haojin2
Copy link
Contributor

haojin2 commented Apr 7, 2020

@TaoLv Is it possible for you to submit a single PR with only the update to 3rdparty/mkldnn ?

@TaoLv TaoLv mentioned this pull request Apr 7, 2020
Merged
7 tasks
@TaoLv
Copy link
Member

TaoLv commented Apr 7, 2020

Creating #17991 to fix and closing the reverting PR #17986.

mk-61 pushed a commit to mk-61/incubator-mxnet that referenced this pull request Apr 7, 2020
@Yiyan66
[numpy] add op median (apache#17084)
7f709be 
* part

* wrapper

* sanity
MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 10, 2020
@Yiyan66 @MoisesHer
[numpy] add op median (apache#17084)
525873f 
* part

* wrapper

* sanity
sxjscience pushed a commit to sxjscience/mxnet that referenced this pull request Jul 1, 2020
@Yiyan66 @sxjscience
[numpy] add op median apache#17084
6fe903b
shuo-ouyang pushed a commit to shuo-ouyang/incubator-mxnet that referenced this pull request Aug 9, 2020
@Yiyan66
[numpy] add op median (apache#17084)
917aada 
* part

* wrapper

* sanity
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xidulu xidulu xidulu left review comments

@haojin2 haojin2 haojin2 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees

@haojin2 haojin2

Labels
Numpy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yiyan66 @mxnet-bot @TaoLv @haojin2 @xidulu