Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix desired precision for test_ndarray.py:test_reduce #16992

Merged
merged 2 commits into from
Dec 7, 2019

Conversation

wkcn
Copy link
Member

@wkcn wkcn commented Dec 6, 2019

Description

Hi, there.
I change the testing precision for test_ndarray.py:test_reduce, to make the CI happy.
I have tested it for more than 900 times.

Related Test: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/master/1349/pipeline

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • tiny change. The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Change the testing precision for test_ndarray.py:test_reduce

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@wkcn wkcn added pr-awaiting-review PR is waiting for code review Test labels Dec 6, 2019
@wkcn
Copy link
Member Author

wkcn commented Dec 7, 2019

Hi @apeforest , could you please help take a review? Thank you!

@wkcn wkcn merged commit 93cf48d into apache:master Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant