Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] add op tensorinv #16981

Merged
merged 1 commit into from
Dec 16, 2019
Merged

[Numpy] add op tensorinv #16981

merged 1 commit into from
Dec 16, 2019

Conversation

sjtuWangDing
Copy link
Contributor

Description

add op tensorinv

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@haojin2 haojin2 self-assigned this Dec 5, 2019
@haojin2 haojin2 added the Numpy label Dec 5, 2019
@sjtuWangDing sjtuWangDing force-pushed the linalg_tensorinv branch 2 times, most recently from 868b224 to 48defef Compare December 6, 2019 04:24
@sjtuWangDing sjtuWangDing force-pushed the linalg_tensorinv branch 3 times, most recently from b231e7c to 2ba186e Compare December 9, 2019 01:40
haojin2
haojin2 approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please resolve the conflicts

@sjtuWangDing sjtuWangDing force-pushed the linalg_tensorinv branch 2 times, most recently from 9f17f1c to 5fe5960 Compare December 11, 2019 12:26
fix precision problem in linalg_solve, linalg_tensorinv, linalg_chole…
5632660 
…sky op test

fix format
set atol=rtol=1e-1 in test_np_linalg_cholesky
fix test_np_linalg_tensorinv
fix bug in test_np_linalg_tensorinv
commit tensorinv src
@haojin2 haojin2 merged commit 7dbb4b7 into apache:master Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@haojin2 haojin2 haojin2 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees

@haojin2 haojin2

Labels
Numpy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjtuWangDing @haojin2