Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Include eval_net the validation model in the estimator api #16957

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

liuzh47
Copy link
Contributor

@liuzh47 liuzh47 commented Dec 2, 2019

Description

We add validation model eval_net to the base estimator API. Users may use different models during training and validation. In this PR, we make the following contribution:

  • We add the implementation of eval_net in the estimator class
  • We add unit test for the introduced feature to ensure that parameter sharing works correctly for self.eval_net and self.net

Fixes issue #16942.

@leezu leezu added the R1.6.0 label Dec 10, 2019
@leezu leezu merged commit e18e4ce into apache:master Dec 10, 2019
@leezu
Copy link
Contributor

leezu commented Dec 10, 2019

CC @ptrendx part of the #16922, #16900 series. If feasible, let's also include it.

ptrendx pushed a commit to ptrendx/mxnet that referenced this pull request Dec 10, 2019
…che#16957)

* Include eval_net the validation model in the estimator api

* fix small issue
ptrendx added a commit that referenced this pull request Dec 11, 2019
* Include eval_net the validation model in the gluon estimator api (#16957)

* Include eval_net the validation model in the estimator api

* fix small issue

* Extend estimator.evaluate() to support event handlers (#16971)



* fix unittest failures for the new api interface

* Add comments in the code for readability

* Remove unused argument val_metrics

* merge changes with the master branch

* fix some regression errors

* fix bugs introduced in the merging phase

* Add support of plug and play fit_batch and evaluate_batch (#16982)

* Add support of plug and play fit_batch and evaluate_batch

* Add check for the validity of the estimator model

* Rename estimator model as batch processor

* Remove unused import

* Add documentation of the batch processor class

* refine the documentation of the batch processor

* Fix merge bugs

* fix bugs introduced during merge

* fix sanity check failures

* fix CI bugs

* Fix Gluon Estimator nightly test (#17042)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants