Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix crashing on Windows in ObjectPool ~ctor #16941

Merged
merged 4 commits into from
Dec 7, 2019

Conversation

dmitry-markeshov
Copy link
Contributor

Description

On Windows in ObjectPool ~ctor _aligned_free should be used instead free
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/aligned-malloc?view=vs-2019

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wkcn wkcn added the pr-awaiting-review PR is waiting for code review label Dec 6, 2019
@wkcn wkcn merged commit 083efb8 into apache:master Dec 7, 2019
@wkcn
Copy link
Member

wkcn commented Dec 7, 2019

Merged. Thank you for the fix : )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug pr-awaiting-review PR is waiting for code review Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants