Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Implement atleast_1d, atleast_2d, atleast_3d #16914

Closed
wants to merge 9 commits into from

Conversation

juxtaly
Copy link
Contributor

@juxtaly juxtaly commented Nov 26, 2019

Description

Implement atleast_1d, atleast_2d, atleast_3d

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • atleast_1d, tests
  • atleast_2d, tests
  • atleast_3d, tests

@juxtaly juxtaly requested a review from szha as a code owner November 26, 2019 20:24
@haojin2 haojin2 self-assigned this Nov 26, 2019
@haojin2 haojin2 added the Numpy label Nov 26, 2019
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add operator dispatch and interoperability tests.

Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 mentioned this pull request Dec 17, 2019
7 tasks
@haojin2
Copy link
Contributor

haojin2 commented Jan 6, 2020

#17099 merged, closing this one.

@haojin2 haojin2 closed this Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants