Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Bump up atol for gradient check in gluon.test_hybrid_static_memory #16843

Merged
merged 1 commit into from
Nov 17, 2019
Merged

Bump up atol for gradient check in gluon.test_hybrid_static_memory #16843

merged 1 commit into from
Nov 17, 2019
+1 −1

Conversation

ChaiBapchya
Copy link
Contributor

@ChaiBapchya ChaiBapchya commented Nov 17, 2019 •
edited
Loading

Description

Fixes #11809

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Code is well-documented:
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@ChaiBapchya
Copy link
Contributor Author

@haojin2 @anirudh2290

haojin2
haojin2 approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 merged commit 5a97cf5 into apache:master Nov 17, 2019
@ChaiBapchya ChaiBapchya deleted the fix_hybrid_static branch January 21, 2020 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@haojin2 haojin2 haojin2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test: test_hybrid_static_memory
2 participants
@ChaiBapchya @haojin2