Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Gluon] Improve estimator usability and fix logging logic #16810

Merged
merged 6 commits into from
Nov 16, 2019

Commits on Nov 14, 2019

  1. Fix doc

    leezu committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    799f04b View commit details
    Browse the repository at this point in the history
  2. Remove warning

    leezu committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    ae9647b View commit details
    Browse the repository at this point in the history
  3. Don't use global logger. Make it specific to each estimator.

    gluon.contrib.estimator used a global Logger obtained via
    `logging.getLogger('gluon.contrib.estimator.event_handlers')`. This logger used
    to be configured every time a gluon.contrib.estimator.LoggingHandler was
    created, which is a bug. We can't modify a global Logger instance whenever the
    user creates an Estimator and a LoggingHandler.
    
    Instead, this commit separates the LoggingHandler (responsible for logging
    metadata during estimator.fit) from the configuration of the Logger.
    
    We expose the Logger as attribute of the Estimator, and configure it to output
    to stdout by default. Instructions are given how users can configure the
    Estimator.logger to log to a file instead.
    leezu committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    2bcdedc View commit details
    Browse the repository at this point in the history
  4. Fix

    leezu committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    8354b1b View commit details
    Browse the repository at this point in the history
  5. Fix and clarify doc

    leezu committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    c47217e View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. Workaround problems on Windows

    leezu committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    1b43c5a View commit details
    Browse the repository at this point in the history