Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Link fixes4 #16764

Merged
merged 5 commits into from
Nov 13, 2019
Merged

Link fixes4 #16764

merged 5 commits into from
Nov 13, 2019

Conversation

TEChopra1000
Copy link
Contributor

A new round of link fixes.

Copy link
Member

@iblislin iblislin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Julia part is fine for me. 👍

@@ -31,7 +31,7 @@ networks yet, the example shown here is an implementation of LSTM by
using the default FeedForward model via explicitly unfolding over time.
We will be using fixed-length input sequence for training. The code is
adapted from the [char-rnn example for MXNet's Python
binding](https://github.com/dmlc/mxnet-notebooks/blob/master/python/tutorials/char_lstm.ipynb),
binding](/api/r/docs/tutorials/char_rnn_model),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, is there a Python tutorial on the web site?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, I think it's R's, not Python.

Copy link
Contributor Author

@TEChopra1000 TEChopra1000 Nov 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice, that's the correct one.

Copy link
Contributor Author

@TEChopra1000 TEChopra1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed site-link for python char-rnn tutorial.

julia/docs/src/tutorial/char-lstm.md Outdated Show resolved Hide resolved
@ChaiBapchya
Copy link
Contributor

ChaiBapchya commented Nov 11, 2019

@aaronmarkham @TEChopra1000
The reason why you were facing MKLDNN lib error was
Your branch was likely not updated with latest master

Your error - MKLDNN lib not found - #16629
Fixed in this PR - #16690
Needs to be included in your branch.

Steps to merge

git remote add upstream https://github.com/apache/incubator-mxnet

git checkout master
git fetch upstream master
git merge upstream/master
git push origin master

This updates your master
Now update your feature branch

git checkout <branchname>
git merge master
git push origin <branchname>

Hope this helps.

@TEChopra1000
Copy link
Contributor Author

@aaronmarkham would you be willing to merge these link fixes?

Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged!

@iblislin iblislin merged commit 47fd3a0 into apache:master Nov 13, 2019
@TEChopra1000 TEChopra1000 deleted the link_fixes4 branch December 2, 2019 22:14
@@ -267,8 +267,7 @@ finetune_net.export("flower-recognition", epoch=epochs)
MXNet provides various useful tools and interfaces for deploying your model for inference. For example, you can use [MXNet Model Server](https://github.com/awslabs/mxnet-model-server) to start a service and host your trained model easily.
Besides that, you can also use MXNet's different language APIs to integrate your model with your existing service. We provide [Python](/api/python.html), [Java](/api/java.html), [Scala](/api/scala.html), and [C++](/api/cpp) APIs.

Here we will briefly introduce how to run inference using Module API in Python. There is more detailed explanation available in the [Predict Image Tutorial](https://mxnet.apache.org/tutorials/python/predict_image.html).
In general, prediction consists of the following steps:
Here we will briefly introduce how to run inference using Module API in Python. In general, prediction consists of the following steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the broken link discussed in #16724

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add it back? or the image-classification shouldn't exist anymore? What's the solution for that issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChaiBapchya #16724 is still open, I wondered if something is pending. I personally don't know the expect solution, if everything is good we can close it.

But following link was mentioned in the issue, not sure if this need to be considered.

True link should be -- https://github.com/dmlc/mxnet-notebooks/blob/master/python/tutorials/predict_imagenet.ipynb

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there was a link which previously existed. Now the link has been removed. Have a word with Aaron/Talia they have a better idea.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants