Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update submodule dmlc-core #16742

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

DickJC123
Copy link
Contributor

Description

This PR advances the 3rdparty dmlc-core submodule by the following 2 commits:

ca9f932  2019-11-05  Dick Carter            Fix initial-release nvcc v10.1 issue with thread_local.h (#579)
05fb5ad  2019-10-24  Philip Hyunsu Cho      Make yarn.py and launcher.py compatible with Python 3 (#564)

Importantly, this pulls in dmlc-core PR dmlc/dmlc-core#579, which is the work-around for MXNet issue #16612. Once this is merged, an MXNet build against the initial release of cuDNN v10.1 will not fail. The version of dmlc-core included as a submodule of 3rdparty/tvm will not change of course (it depends on the tvm submodule hash), but this is not causing a compile problem for MXNet.

@larroy

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • [X ] Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@anirudh2290
Copy link
Member

preferrably this should also go in 1.6 if we are still taking bug fixes.

Copy link
Contributor

@larroy larroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this @DickJC123. LGTM

@anirudh2290 anirudh2290 merged commit ecb7a3a into apache:master Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants