This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix encode write error with windows. #16738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajiedesign
force-pushed
the
fix_encode
branch
from
9bf1b69
to
ed1c810
Compare
yajiedesign
requested review from
aaronmarkham,
anirudh2290,
eric-haibin-lin,
gigasquid,
iblislin,
marcoabreu,
nswamy,
sergeykolychev and
yzhliu
as code owners
…ng="utf-8",it fix some encode error in Chinese windows system.
yajiedesign
force-pushed
the
fix_encode
branch
from
ed1c810
to
f4cbd3d
Compare
yajiedesign
removed request for
gigasquid,
yzhliu,
iblislin,
nswamy,
anirudh2290,
eric-haibin-lin,
aaronmarkham,
marcoabreu and
sergeykolychev
stu1130
approved these changes
Nov 10, 2019
TaoLv
approved these changes
Nov 10, 2019
frankfliu
pushed a commit
to frankfliu/incubator-mxnet
that referenced
this pull request
Jan 13, 2020
…ng="utf-8",it fix some encode error in Chinese windows system. (apache#16738)
frankfliu
pushed a commit
to frankfliu/incubator-mxnet
that referenced
this pull request
Jan 22, 2020
…ng="utf-8",it fix some encode error in Chinese windows system. (apache#16738)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change _generate_op_module_signature get_module_file open with encoding="utf-8",it fix some encode error in Chinese windows system.