Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix encode write error with windows. #16738

Merged
merged 1 commit into from
Nov 10, 2019
Merged

Conversation

yajiedesign
Copy link
Contributor

change _generate_op_module_signature get_module_file open with encoding="utf-8",it fix some encode error in Chinese windows system.

…ng="utf-8",it fix some encode error in Chinese windows system.
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@TaoLv TaoLv merged commit 57b9b2c into apache:master Nov 10, 2019
@szha szha mentioned this pull request Nov 14, 2019
5 tasks
frankfliu pushed a commit to frankfliu/incubator-mxnet that referenced this pull request Jan 13, 2020
…ng="utf-8",it fix some encode error in Chinese windows system. (apache#16738)
frankfliu pushed a commit to frankfliu/incubator-mxnet that referenced this pull request Jan 22, 2020
…ng="utf-8",it fix some encode error in Chinese windows system. (apache#16738)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants