This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Support boolean elemwise/broadcast binary add, multiply and true_divide #16728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjolivier01
approved these changes
Nov 5, 2019
cjolivier01
reviewed
Nov 5, 2019
haojin2
force-pushed
the
bool_binary_ops
branch
2 times, most recently
from
4c0464d
to
f254deb
Compare
haojin2
changed the title
haojin2
force-pushed
the
bool_binary_ops
branch
3 times, most recently
from
2e76582
to
c12dd57
Compare
haojin2
force-pushed
the
bool_binary_ops
branch
from
c12dd57
to
ac03a24
Compare
reminisce
approved these changes
Nov 11, 2019
|
@ptrendx This is needed for 1.6.0 for d2l book english version. |
ptrendx
pushed a commit
to ptrendx/mxnet
that referenced
this pull request
Nov 15, 2019
…de (apache#16728) * support pure boolean elemwise/broadcast binary op * switch to unique_tpr * fix the test error
ptrendx
added a commit
that referenced
this pull request
Nov 16, 2019
…, #16792) (#16832) * Fix nightly build (#16773) * Remove dependency on tvmop.conf * Fix binaries dependencies for ni nightly * Add comments * Update tvmop.py * Fix rebase * Fix (#16781) * Speed fused_op compilation by caching ptx and jit-compiled functions (#16783) * [Numpy] Fix collect_params().zero_grad() in gluon numpy interface (#16716) * fix zero_grad * Update parameter.py * add test * fix * Mixed data type binary ops (#16699) * support mixed-precision binary operations * improvement for documentations and error messages * Support boolean elemwise/broadcast binary add, multiply and true_divide (#16728) * support pure boolean elemwise/broadcast binary op * switch to unique_tpr * fix the test error * Fix rtrue_divide grad (#16769) * Fix rtrue_divide_scalar * More tests * Fix numpy-compatible mean output type for integer inputs (#16792) * fix mean output type for integer inputs * enable for windows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support operations between 2 boolean-typed tensors, currently
add,multiplyandtrue_divideare supported and tested.Has quite a few conflict with #16699, suggesting merging #16699 before merging this one.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
To support the tuning for
booltype,operator_tune'sdata_set_buffer is changed to be malloc'd instead of usingstd::vectordue to stl's special implementation.@cjolivier01 FYI