Remove unused files in Website doc #16722
Conversation
|
Turns out the CI is failing coz register.py uses _build_doc Does this mean I can remove rest of the contents of the symbol_doc and ndarray_doc files but keep the _build_doc function since it is being used here @aaronmarkham @sojiadeshina can either of you confirm? Thanks |
ChaiBapchya
force-pushed
the
remove_unused_file
branch
from
f1b7b49
to
726773b
Compare
|
I've gone ahead and made the change. |
ChaiBapchya
force-pushed
the
remove_unused_file
branch
from
a8977a1
to
342e80a
Compare
|
@mxnet-bot run ci [all] |
|
Jenkins CI successfully triggered : [centos-cpu, miscellaneous, unix-cpu, centos-gpu, edge, clang, unix-gpu, website, windows-cpu, windows-gpu, sanity] |
|
@mxnet-bot run ci [all] |
|
Jenkins CI successfully triggered : [miscellaneous, edge, sanity, clang, website, windows-cpu, centos-cpu, unix-gpu, centos-gpu, unix-cpu, windows-gpu] |
| @@ -54,7 +54,7 @@ def _trim_container_id(cid): | |||
| return cid[:12] | |||
|
|
|||
| def __init__(self): | |||
| self._docker_client = docker.from_env() | |||
| self._docker_client = docker.from_env(timeout=None) | |||
There was a problem hiding this comment.
@marcoabreu FYI after rebuilding our Unix CPU Jenkins Slave AMI via the scripts in https://github.com/apache/incubator-mxnet-ci/ we intermittently run into docker/docker-py#2266 .
The rootcause is that when a new instance is spawned, booted, Docker agent started and Jenkins immediately requests starting a container, docker may take longer than 60 seconds to finish the startup. In the log, line 294 to 295 you can see that the startup took 70 seconds, triggering the timeout.
The issue is tracked upstream at docker/docker-py#2266 and appears to be a regression in Docker. (Note that we're using a 2 year old Docker version previously, as the AMI hasn't been regenerated.)
Considering we're talking about a socket connecting to localhost, we have no risk of connection issues and do not need to use a timeout.
Added the fix to this PR, as this PR experienced the issue and is ready to be merged.
Description
After the revamping of the MXNet website, we no longer need lots of docs from
Only the _build_doc functions described in these 2 docs are used. Hence keeping that and yanking the rest.
Realized this while closing my previous PR - #14243
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
@aaronmarkham @sojiadeshina Please confirm