This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
update default windows Visual Studio from 2015 to 2017 #16712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified by building on Windows with following commands |
|
How did you verify exactly? CI is failing 🙈 |
|
Ooops (I forgot i had manually upgraded the opencv version on windows instance) |
6 tasks
|
Closing in favor of #17962 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently on CI, windows instances contained both VS2015 and 2017.
However, the default is 2015 and that's the one used for CI Builds
Aim is to update the VSCode build to latest (ideally 2019) but for now transitioning to 2017 (and then to 2019)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.