Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix numpy bugs #16537

Merged
merged 16 commits into from
Oct 20, 2019
Merged

Fix numpy bugs #16537

merged 16 commits into from
Oct 20, 2019

Conversation

reminisce
Copy link
Contributor

Description

This PR fixed several things.

  1. Legacy NDArray __setitem__ now works in the following case. @astonzhang
>>> import mxnet as mx
>>> a = mx.nd.ones((2, 3))
>>> b = mx.nd.zeros((1, 1, 1, 1, 1, 3))
>>> a[0] = b
>>> a

[[0. 0. 0.]
 [1. 1. 1.]]
<NDArray 2x3 @cpu(0)>
  1. np.true_divide supports integral dtypes and outputs float32. @haojin2

  2. Loading legacy symbol json files in np_shape semantics. @stu1130 @frankfliu

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@reminisce reminisce requested a review from szha as a code owner October 18, 2019 18:14
@haojin2 haojin2 self-assigned this Oct 18, 2019
@haojin2 haojin2 added the Numpy label Oct 18, 2019
@reminisce reminisce force-pushed the fix_numpy_bugs branch 5 times, most recently from 2da0a29 to 00e43aa Compare October 20, 2019 04:16
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a pending change later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants