This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix broken links fix more broken links
aaronmarkham
force-pushed
the
broken_links_aaron
branch
2 times, most recently
from
October 16, 2019 13:48
cd213b7
to
6f90557
Compare
aaronmarkham
requested review from
anirudh2290,
eric-haibin-lin,
iblislin and
marcoabreu
as code owners
October 16, 2019 13:48
aaronmarkham
force-pushed
the
broken_links_aaron
branch
from
October 16, 2019 13:50
6f90557
to
d1897a6
Compare
aaronmarkham
commented
Oct 16, 2019
aaronmarkham
commented
Oct 16, 2019
@@ -91,7 +91,7 @@ In the case of distributed training though, we would need to divide the dataset | |||
|
|||
Typically, this split of data for each worker happens through the data iterator, | |||
on passing the number of parts and the index of parts to iterate over. | |||
Some iterators in MXNet that support this feature are [mxnet.io.MNISTIterator]({{'/api/python/docs/api/gluon-related/_autogen/mxnet.io.MNISTIter.html#mxnet.io.MNISTIter'|relative_url}}) and [mxnet.io.ImageRecordIter]({{'/api/python/docs/api/gluon-related/_autogen/mxnet.io.ImageRecordIter.html#mxnet.io.ImageRecordIter'|relative_url}}). | |||
Some iterators in MXNet that support this feature are [mxnet.io.MNISTIterator]({{'//api/mxnet/io/index.html#mxnet.io.MNISTIter'|relative_url}}) and [mxnet.io.ImageRecordIter]({{'/api/mxnet/io/index.html#mxnet.io.ImageRecordIter'|relative_url}}). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThomasDelteil what are these fancy urls all about? In what context should they be used?
aaronmarkham
commented
Oct 16, 2019
docs/python_docs/python/tutorials/packages/onnx/super_resolution.md
Outdated
Show resolved
Hide resolved
aaronmarkham
commented
Oct 16, 2019
docs/python_docs/python/tutorials/packages/onnx/fine_tuning_gluon.md
Outdated
Show resolved
Hide resolved
aaronmarkham
commented
Oct 16, 2019
docs/python_docs/python/tutorials/packages/onnx/inference_on_onnx_model.md
Outdated
Show resolved
Hide resolved
aaronmarkham
removed request for
iblislin,
anirudh2290,
szha,
eric-haibin-lin and
marcoabreu
October 16, 2019 13:58
@IvyBazan @TEChopra1000 - can you review? |
TEChopra1000
suggested changes
Oct 16, 2019
docs/python_docs/python/tutorials/packages/gluon/blocks/hybridize.md
Outdated
Show resolved
Hide resolved
docs/python_docs/python/tutorials/packages/gluon/blocks/hybridize.md
Outdated
Show resolved
Hide resolved
docs/python_docs/python/tutorials/packages/ndarray/gotchas_numpy_in_mxnet.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Talia <[email protected]>
@@ -28,7 +28,7 @@ In this tutorial, we will learn how to use MXNet to ONNX exporter on pre-trained | |||
## Prerequisites | |||
|
|||
To run the tutorial you will need to have installed the following python modules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
To run the tutorial you will need to have installed the following python modules: | |
To run the tutorial, install the following Python modules: |
@@ -28,7 +28,7 @@ In this tutorial, we will learn how to use MXNet to ONNX exporter on pre-trained | |||
## Prerequisites | |||
|
|||
To run the tutorial you will need to have installed the following python modules: | |||
- [MXNet >= 1.3.0](http://mxnet.apache.org/install/index.html) | |||
- [MXNet >= 1.3.0](/get_started) | |||
- [onnx]( https://github.com/onnx/onnx#installation) v1.2.1 (follow the install guide) | |||
|
|||
*Note:* MXNet-ONNX importer and exporter follows version 7 of ONNX operator set which comes with ONNX v1.2.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
*Note:* MXNet-ONNX importer and exporter follows version 7 of ONNX operator set which comes with ONNX v1.2.1. | |
*Note:* MXNet-ONNX importer and exporter follows version 7 of ONNX operator set, which comes with ONNX v1.2.1. |
1. Use [Amazon SageMaker](https://aws.amazon.com/sagemaker/developer-resources/) | ||
1. Use the [AWS Deep Learning AMI with Conda](https://docs.aws.amazon.com/dlami/latest/devguide/overview-conda.html) (comes preinstalled!) | ||
1. Use an [AWS Deep Learning Container](https://docs.aws.amazon.com/dlami/latest/devguide/deep-learning-containers.html) | ||
1. Install MXNet on a [AWS Deep Learning Base AMI](https://docs.aws.amazon.com/dlami/latest/devguide/overview-base.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
1. Install MXNet on a [AWS Deep Learning Base AMI](https://docs.aws.amazon.com/dlami/latest/devguide/overview-base.html) | |
1. Install MXNet on an [AWS Deep Learning Base AMI](https://docs.aws.amazon.com/dlami/latest/devguide/overview-base.html) |
TEChopra1000
approved these changes
Oct 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots more to do, but let's get some fixes in there!