Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Proper handling of "allow_np_array" attribute in optimizer #16494

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Oct 15, 2019

Description

As title.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Fix of the logic
  • Unit test

Comments

@eric-haibin-lin @reminisce

@haojin2 haojin2 added the Numpy label Oct 15, 2019
@haojin2 haojin2 self-assigned this Oct 15, 2019
@eric-haibin-lin eric-haibin-lin merged commit 0c00a79 into apache:master Oct 16, 2019
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants