Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Doc] Update the download page with 1.5.1 release #16442

Merged
merged 5 commits into from
Oct 15, 2019

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Oct 11, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@TaoLv
Copy link
Member Author

TaoLv commented Oct 11, 2019

@aaronmarkham @ThomasDelteil @szha Please help to review and merge. Thanks!

Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the guide mention when the links transition to archive? I believe that's part of the release maintenance too. Otherwise, this looks fine.

@ThomasDelteil
Copy link
Contributor

@TaoLv
Copy link
Member Author

TaoLv commented Oct 12, 2019

@ThomasDelteil, I have changed the versions and the pip package table. Could you please take a look again?
@aaronmarkham, Not sure I understand the question. The artifacts of these download links have already been archived here: https://apache.org/dist/incubator/mxnet/1.5.1/.

@TaoLv
Copy link
Member Author

TaoLv commented Oct 15, 2019

Is it good to merge now? @ThomasDelteil @aaronmarkham

@ThomasDelteil ThomasDelteil merged commit 9ab428e into apache:master Oct 15, 2019
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
* update download page

* update get_started page
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants