Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Disabling installation nightly test #16418

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Conversation

mseth10
Copy link
Contributor

@mseth10 mseth10 commented Oct 10, 2019

Description

Disabling installation nightly test as there is a bug in the test script which causes nightly tests to fail. #16417

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mseth10
Copy link
Contributor Author

mseth10 commented Oct 10, 2019

@larroy @aaronmarkham please review

Copy link
Contributor

@larroy larroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since install instructions are gone, we need to disable this failing test to unblock nightly pipeline. The team will look at validating installation instructions in subsequent PRs or find a solution for this.

@mseth10
Copy link
Contributor Author

mseth10 commented Oct 10, 2019

@aaronmarkham @marcoabreu can you please merge?

@marcoabreu marcoabreu merged commit cfe9e50 into apache:master Oct 10, 2019
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
@mseth10 mseth10 deleted the skip_test branch June 1, 2020 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants