-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[DOC] fix installation selector wrong history #16381
Conversation
@aaronmarkham I can't find the s3 preview link in the PR check anymore. Where can I find it? |
Any particular reason you're removing the history push? |
@szha the s3 PR preview has been disabled for now, links have been prettified which means we need an apache web server to render the website properly since we rely on .htaccess rewrite rules to expand URLs. |
Thanks for the PR @szha, I see what happened there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know until we get back the PR preview back it's not simple to test the changes, apologies for that, the simplest way currently to test the front end is to build the website using:
ci/build.py --docker-registry mxnetci --platform ubuntu_cpu_jekyll /work/runtime_functions.sh build_jekyll_docs
@ThomasDelteil thanks for the review. I will address them soon. @marcoabreu I'm not removing the history push. I refactored that part of the code by moving the repetition out of the conditional clauses. |
Oh yeah now I see it. Sorry about that |
Are there some examples? Could we use s3 for that? Hosting through a webserver will increase operational cost. |
@szha, on the cost front: I think a smartly hosted webserver with symlinks for same files across websites vs 200MB for every commits on every PR on s3 will have a comparable operational cost. I don't think we need a very powerful machine, a C4 ~40$/month should be plenty. Which is a drop compared to the CI cost itself. Examples are like this: |
@szha committed the updates, tested here: http://54.211.76.74/get_started |
* fix installation selector wrong history * updates to script * nudge CI
Description
fix installation selector wrong history. it current hardcodes to the index page.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes