Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[DO NOT SQUASH MERGE] Batch merge NumPy operators #16378

Merged
merged 4 commits into from
Oct 7, 2019
Merged

[DO NOT SQUASH MERGE] Batch merge NumPy operators #16378

merged 4 commits into from
Oct 7, 2019

Conversation

reminisce
Copy link
Contributor

Description

Batch merging some operators which have been reviewed and approved.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@reminisce reminisce requested a review from szha as a code owner October 5, 2019 05:09
@ckt624 @reminisce
Implements ldexp. (#15845)
c5005e4 
Remove spaces.

Change tests.

Reorganize files.

Change styles.

Add spaces
@ckt624 @reminisce
Numpy Operators: Inner, Outer, vdot (#15846)
fbfb7d3 
* Implements tensordot and dot.

Change tests.

Add spaces.

Reorganize codes.

Implements inner, outer, vdot.

Remove spaces.

Change tests.

change test format.

Change indent.

Change styles

* Fix
@ckt624 @reminisce
Numpy det and slogdet operators (#15861)
66e03c5 
* Add alias.

Add tests.

Add slogdet tests.

Add docs

Change shapes

Change tests.

Change slogdet tests

Change style.

* Fix

* Fix
@reminisce
Fix random op signature
9f14e75 
Fix weight shape inference using uniform/normal

Delete absolute_import
xidulu
xidulu approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@xidulu xidulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM regarding the changes on random op signature

@reminisce reminisce merged commit 4940ec0 into master Oct 7, 2019
@szha szha deleted the numpy_prs branch August 13, 2020 04:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xidulu xidulu xidulu approved these changes

@marcoabreu marcoabreu marcoabreu approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reminisce @marcoabreu @xidulu @ckt624