Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

npi.boolean_mask_assign_(scalar, tensor) operator for future boolean indexing #16361

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Oct 2, 2019

Description

A step toward boolean indexing such as:

a[mask] = val

where mask is a boolean array and val is either a scalar value/scalar tensor/vector of values

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Forward operator
  • Unit tests

Comments

MXNET_TEST_COUNT=10000 nosetests tests/python/gpu/test_operator_gpu.py:test_npi_boolean_assign
[INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=7083872 to reproduce.
.
----------------------------------------------------------------------
Ran 1 test in 187.052s

OK
MXNET_TEST_COUNT=10000 nosetests tests/python/unittest/test_numpy_op.py:test_npi_boolean_assign
.
----------------------------------------------------------------------
Ran 1 test in 115.251s

OK

@haojin2 haojin2 added the Numpy label Oct 2, 2019
@haojin2 haojin2 requested a review from reminisce October 2, 2019 23:51
@haojin2 haojin2 self-assigned this Oct 2, 2019
@haojin2 haojin2 changed the title boolean_mask_assign operator for future boolean indexing npi.boolean_mask_assign_(scalar, tensor) operator for future boolean indexing Oct 2, 2019
@haojin2 haojin2 force-pushed the np_boolean_mask_assign branch 2 times, most recently from 1c10800 to b882e18 Compare October 3, 2019 07:44
@reminisce reminisce merged commit 916fbf2 into apache:master Oct 4, 2019
@haojin2 haojin2 deleted the np_boolean_mask_assign branch October 17, 2019 07:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants