This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix atol for test_preloaded_multi_sgd #16356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaiBapchya
reviewed
Oct 2, 2019
There was a problem hiding this comment.
Thanks for the quick fix. @Caenorst
Can you add "Fixes #PR" that would auto close the issue if/when this PR gets merged.
Thanks again for testing it 10k times before the PR!
| @@ -396,7 +396,7 @@ def _assert_all_almost_equal(lhs_list, rhs_list, rtol, atol): | |||
| assert_almost_equal(lhs.asnumpy(), rhs.asnumpy(), rtol=rtol, atol=atol) | |||
| if dtype == 'float16': | |||
| rtol = 1e-3 | |||
| atol = 1e-3 | |||
| atol = 1e-2 | |||
| else: | |||
| rtol = 1e-5 | |||
| atol = 1e-6 | |||
There was a problem hiding this comment.
what about when its !float16?
There was a problem hiding this comment.
I'm testing 10k including non fp16, so I guess the other tolerances are fine
|
Generally in the description of the PR |
anirudh2290
approved these changes
Oct 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix atol for test_preloaded_multi_sgd
Following Issue: #16345
Fixes #16122
Checklist
Essentials
Changes
Comments